Skip to content

Commit

Permalink
compliance stats + action-report improvements/fixes: include all …
Browse files Browse the repository at this point in the history
…non-invited users in `compliance stats` output, standardize char casing in emails for string comparison in `action-report` + release version update
  • Loading branch information
aaunario-keeper committed Apr 1, 2024
1 parent 1c7b3d3 commit 9760961
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion keepercommander/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
# Contact: ops@keepersecurity.com
#

__version__ = '16.10.10'
__version__ = '16.10.11'
2 changes: 1 addition & 1 deletion keepercommander/commands/aram.py
Original file line number Diff line number Diff line change
Expand Up @@ -1895,7 +1895,7 @@ def adjust_filter(q_filter, max_ts=0):
rq = report_rq(query_filter, req_limit, cols, report_type='span')
rs = api.communicate(params, rq)
events = rs['audit_event_overview_report_rows']
to_exclude = {event.get(username_field) for event in events}
to_exclude = {event.get(username_field, '').lower() for event in events}
excluded.update(to_exclude.intersection(candidate_usernames))
end = int(events[-1]['last_created']) if events else 0
done = (len(events) < req_limit
Expand Down
4 changes: 2 additions & 2 deletions keepercommander/commands/compliance.py
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,11 @@ def get_row(u):
'users': True,
'quiet': True,
'format': 'json',
'node': str(node) if filter_by_node else None,
'pattern': 'active'
'node': str(node) if filter_by_node else None
}
cmd_rs = partial(cmd.execute, params, **cmd_kwargs)()
managed_users = json.loads(cmd_rs)
managed_users = [mu for mu in managed_users if mu.get('status', '').lower() != 'invited']
managed_user_email_lookup = {mu.get('user_id'): mu.get('email') for mu in managed_users}
managed_user_ids = set(managed_user_email_lookup.keys())
empty_vault_user_ids = {user_id for user_id in managed_user_ids if user_id not in sox_data.get_users()}
Expand Down

0 comments on commit 9760961

Please sign in to comment.