Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Login: fix app hanging when browser proxy/manager fails to launch due to missing requirements (KC-787) #1261

Merged
merged 1 commit into from
Jun 29, 2024
Merged

SSO Login: fix app hanging when browser proxy/manager fails to launch due to missing requirements (KC-787) #1261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions keepercommander/auth/console_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ def on_password(self, step):
def on_sso_redirect(self, step):
try:
wb = webbrowser.get()
wrappers = set('xdg-open|gvfs-open|gnome-open|x-www-browser|www-browser'.split('|'))
browsers = set(webbrowser._browsers if hasattr(webbrowser, '_browsers') else {})
standalones = browsers - wrappers
if browsers and not standalones: # show browser-launch option only if effectively supported
wb = None
except:
wb = None

Expand Down
Loading