Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): mount instead of copy in Dockerfile #334

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

KeisukeYamashita
Copy link
Owner

@KeisukeYamashita KeisukeYamashita commented Jul 26, 2024

Why

Because this layer is not needed. We can improve it.

Summary by CodeRabbit

  • Chores
    • Updated the .gitignore file to improve version control management by excluding unnecessary files in Rust projects, enhancing repository cleanliness.
    • Optimized the Dockerfile for better build performance by modifying the application installation process, which may reduce image size and build time.

Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@KeisukeYamashita KeisukeYamashita self-assigned this Jul 26, 2024
Copy link

coderabbitai bot commented Jul 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the project's .gitignore and Dockerfile, refining file management and build efficiency. The .gitignore now effectively excludes unnecessary files specific to Rust projects, while the Dockerfile optimizes the application build process using a bind mount, improving performance and reducing image size. These updates contribute to a cleaner repository and streamlined development workflow.

Changes

File(s) Change Summary
.gitignore Expanded to include Rust-specific files and directories, improving exclusion of unnecessary files.
Dockerfile Replaced COPY . . with RUN --mount=type=bind,target=. cargo install --path . for better build performance.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Host
    participant Docker
    Developer->>Docker: Initiates build process
    Docker->>Host: Access project files through bind mount
    Docker->>Docker: Executes cargo install
    Docker->>Developer: Build completed
Loading

🐰 In the garden of code, I hop with glee,
New files ignored, as happy as can be!
With Docker’s embrace, my builds run so fast,
Clean and efficient, let’s make this last!
A joyful dance, in the code we trust,
For every change, we grow and adjust! 🌱

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

@KeisukeYamashita KeisukeYamashita changed the title chore: mount instead of copy in Dockerfile chore(cli): mount instead of copy in Dockerfile Jul 26, 2024
@KeisukeYamashita KeisukeYamashita merged commit 3bfffe7 into main Jul 26, 2024
19 of 20 checks passed
@KeisukeYamashita KeisukeYamashita deleted the tune-docker branch July 26, 2024 20:04
@coderabbitai coderabbitai bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant