Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding of points distribution #70

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

SyonKuppili
Copy link
Contributor

@SyonKuppili SyonKuppili commented Jul 30, 2023

Hey!
I've added the Points Distribution according to the issue assigned by you.
An animation is added whenever a person gets a right or a wrong answer (which is of +100 and -100.)
I'd also recommend we add a sound effect to this!
Thanks,
Syon

fixes #4

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

It made the other quizzes unplayable though, please add these changes to the other quizzes and make it work. Thanks.

@SyonKuppili
Copy link
Contributor Author

I've added the changes so that it works for every quiz now!

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the animation is not inclusive of the bonus points and only for correct answer shows +100 and wrong shows -100.

Question: Do you think it should show the bonus points?
I think it should. Let me know what you think.

@SyonKuppili
Copy link
Contributor Author

Agreed, I think so too. I'll get working on it.

@SyonKuppili
Copy link
Contributor Author

hey, i found a bug in the point system. when the streak goes to 4, as an elif statement is missing, it resets the streak to 0. ill be fixing this as well, making a streak of 4 to give 300,
a streak of 6,7,8,9 to give 800 and so on.
is this fine?

@SyonKuppili
Copy link
Contributor Author

Hey Kendall! The bonus points animation has been finished and is working well for all topics. Please let me know if you need any more changes!
Thanks, Syon

This reverts commit ef2e06f, reversing
changes made to a776997.
@KendallDoesCoding KendallDoesCoding merged commit b6b11d2 into KendallDoesCoding:main Dec 7, 2023
6 of 8 checks passed
@KendallDoesCoding
Copy link
Owner

Thanks for your contribution @SyonKuppili .. This has made a big impact in the project. Sorry for the delay in merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Figure new points when answer correct/wrong for points distribution
2 participants