Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Time Limit #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

n-keerthi-gayathri
Copy link

@n-keerthi-gayathri n-keerthi-gayathri commented Jan 26, 2024

Related Issue/Addition to code

  • Issue goes here

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Proposed Changes

  • change 1
  • change 2

Additional Info

  • any additional info for context

Checklist:

  • My code follows the style guidelines of this project and have read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots

Original Updated
** original screenshot ** updated screenshot **

Copy link
Owner

@KendallDoesCoding KendallDoesCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Sorry for the late review.. I like the concept of a timer per question. But, it should end the game after the timer has ended and not go into the negatives.

@KendallDoesCoding KendallDoesCoding mentioned this pull request Apr 11, 2024
13 tasks
@KendallDoesCoding
Copy link
Owner

Please work alongside the author of #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants