Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the Kentico.Xperience.ImageProcessing package dependency needed? #13

Closed
liamgold opened this issue Aug 5, 2024 · 2 comments · Fixed by #14
Closed

Is the Kentico.Xperience.ImageProcessing package dependency needed? #13

liamgold opened this issue Aug 5, 2024 · 2 comments · Fixed by #14

Comments

@liamgold
Copy link
Contributor

liamgold commented Aug 5, 2024

There is a package dependency on Kentico.Xperience.ImageProcessing package, is this actually needed by MiniProfiler? See:

<PackageVersion Include="kentico.xperience.imageprocessing" Version="28.3.1" />

I can't see a reason for it to be included as a dependency, but I might be mistaken?

It would be good to remove this as a dependency if it isn't needed.

@liparova
Copy link

Thanks for sharing your problem. We'll take a look at it soon and consider adding it to the original integration.

@liamgold
Copy link
Contributor Author

I have already done a PR which removes the redundant dependency, it would be great to get that merged

#14

It isn't great that Image Processing is being added to projects through this package, so I'd appreciate if we can merge in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants