Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add stopPropagation calls to dnd handlers #438

Closed
wants to merge 1 commit into from

Conversation

puehringer
Copy link

Fixes #383

Without stopping propagation, libraries like react-mosaic may break the dnd features. This solution has been proposed here as well.

Copy link

vercel bot commented Nov 8, 2024

@puehringer is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm
Copy link
Collaborator

Hey sorry it took a while to review this. We were discussing this and did not believe this is the right fix, as this is a workaround around the react-mosaic-component package, and IMO this should not be fixed at the library level but in userland. Moreover, some other users might be expecting the event to bubble up which this effectively prevents.

I think the right fix would be to expose a prop so the user of the library can provide its drag handle function (more like a render props approach), however, this is more work. Let me know if you would be interested in exploring that approach, otherwise, I would have to close this.

@alessandrojcm
Copy link
Collaborator

Closing as no response, please feel free to open another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and drop features are not working when used in combination with react-mosaic-component
2 participants