Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react 19 - peer deps conflicts - upgrade @tanstack/react-virtual #468

Open
1 task done
AlonMiz opened this issue Jan 7, 2025 · 2 comments
Open
1 task done

Comments

@AlonMiz
Copy link

AlonMiz commented Jan 7, 2025

mantine-react-table version

2.0.0-beta.6

react & react-dom versions

v19

Describe the bug and the steps to reproduce it

we can upgrade to react-virtual 3.11 and we should be ok

https://github.com/TanStack/virtual/releases/tag/v3.11.0

npm WARN Conflicting peer dependency: react-dom@18.3.1
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.8.3
npm WARN   node_modules/mantine-react-table/node_modules/@tanstack/react-virtual
npm WARN     @tanstack/react-virtual@"3.8.3" from mantine-react-table@2.0.0-beta.6
npm WARN     node_modules/mantine-react-table

Minimal, Reproducible Example - (Optional, but Recommended)

no need

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

None

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@AlonMiz AlonMiz closed this as completed Jan 7, 2025
@AlonMiz AlonMiz reopened this Jan 7, 2025
@AlonMiz
Copy link
Author

AlonMiz commented Jan 7, 2025

i see the upgrade is already applied but not yet released?

@alessandrojcm
Copy link
Collaborator

Yes we will release this hopefully soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants