Fix potential crash when using multi-planar images. #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MVKImage add functions to consolidate mapping plane indexes to memory bindings to add safety in situation where one memory binding supports all planes. - Update MoltenVK version to 1.2.8 (unrelated).
cdavis5e
approved these changes
Jan 11, 2024
|
Based on SDK testing, the official MoltenVK 1.2.7 SDK release is out now, so I'm pulling this directly into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKImageadd functions to consolidate mapping plane indexes to memory bindings to add safety in situation where one memory binding supports all planes.This PR fixes an internal design issue uncovered during preliminary testing of PR #2116, the additional functionality of which caused certain CTS tests to crash. This PR fixes those crashes, and potentially other future crashes.
Initially pushing this to a temporary branch, until the current SDK release process is completed.