Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug aids #2305

Closed
wants to merge 2 commits into from
Closed

Debug aids #2305

wants to merge 2 commits into from

Conversation

js6i
Copy link
Collaborator

@js6i js6i commented Aug 9, 2024

Make it a bit easier to debug GPU errors.

@js6i
Stop GPU capture on device loss.
07d7bfb
@js6i
When labeling Metal objects, add a unique identifier.
8068084 
It shows up in the GPU capture and in case of a GPU crash in the crash report.
@billhollings billhollings dismissed a stale review August 14, 2024 22:58

Incomplete.

billhollings
billhollings requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! Good catch on the device failure.

A couple of comments about the labelling.

MoltenVK/MoltenVK/GPUObjects/MVKVulkanAPIObject.h Show resolved Hide resolved
@billhollings billhollings mentioned this pull request Aug 27, 2024
Merged
@billhollings
Copy link
Contributor

PR #2317 is an expanded replacement for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhollings billhollings billhollings requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js6i @billhollings