Fix occasional GPU crash when a smaller descriptor set replaces a larger one. #2355
+136
−187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a descriptor set with fewer than 64 descriptors replaced one with more, the resources it contained were not made resident to the GPU, due to
MVKBitArray
thrashing incorrectly when transitioning between static and dynamic memory allocations.MVKBitArray
design:reset()
is called.realloc()
instead of malloc/copy to improve performance.setXX()
andclearXX()
functions toenableXX()
&disableXX()
.getIndexOfFirstEnabledBit()
&enumerateEnabledBits()
no longer have an option to disable the bit.MVKDescriptorPool
track highest descriptor set allocated, instead of queryingMVKBitArray
.Fixes part of issue #2271.