fix for warning in svm test file #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alycm
approved these changes
Jun 29, 2023
tests/test_openclhpp.cpp
Outdated
| } | ||
| void testSVMMemoryAllocation() | ||
| { | ||
| {// |
There was a problem hiding this comment.
Suggested change
| {// | |
| { |
Something committed accidentally?
tests/test_openclhpp.cpp
Outdated
| @@ -4214,10 +4214,10 @@ void clSVMFree_stubForMemoryAllocation(cl_context context, void *svm_pointer, | |||
| int cmock_num_calls) | |||
| { | |||
| TEST_ASSERT_EQUAL_PTR(svm_pointer, testMemory); | |||
| delete svm_pointer; | |||
| delete (int*) svm_pointer; | |||
There was a problem hiding this comment.
Suggested change
| delete (int*) svm_pointer; | |
| delete[] (int*) svm_pointer; |
As testMemory was allocated with new[] should use delete[]. I realise that problem existed before this PR, but touching the line made me notice it.
There was a problem hiding this comment.
@alycm thanks for patient!
I just repaired.
Please take a look
regards
bashbaug
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue : #236