Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed warning unused function in UT #242

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fixed warning unused function in UT #242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ed1e3
fixed warning unused function in UT
Bogumil-Sapinski-Mobica Jun 23, 2023
47765a4
fixing linking issue
Bogumil-Sapinski-Mobica Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_openclhpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,7 @@ void testBufferConstructorQueueIterator(void)
clReleaseCommandQueue_ExpectAndReturn(make_command_queue(0), CL_SUCCESS);
}

#if CL_HPP_TARGET_OPENCL_VERSION >= 300
static cl_mem clCreateBufferWithProperties_testBufferWithProperties(
cl_context context,
const cl_mem_properties *properties,
Expand All @@ -1334,7 +1335,6 @@ static cl_mem clCreateBufferWithProperties_testBufferWithProperties(

void testBufferWithProperties(void)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this function is used somewhere not compatible with this #if guard change.

{
#if CL_HPP_TARGET_OPENCL_VERSION >= 300
clCreateBufferWithProperties_StubWithCallback(clCreateBufferWithProperties_testBufferWithProperties);

VECTOR_CLASS<cl_mem_properties> props{11};
Expand All @@ -1346,8 +1346,8 @@ void testBufferWithProperties(void)

// prevent destructor from interfering with the test
buffer() = nullptr;
#endif
}
#endif //CL_HPP_TARGET_OPENCL_VERSION >= 300

/****************************************************************************
* Tests for cl::Image1DBuffer
Expand Down
Loading