Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML <extension>: Replace remaining condition with depends #1088

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

XML <extension>: Replace remaining condition with depends #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93f92ab
fix
SunSerega Mar 23, 2024
1529279
Disallow `condition` in extensions
SunSerega Mar 23, 2024
9a0c15e
Merge branch 'main' into cond-to-depend
SunSerega Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xml/cl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6093,7 +6093,7 @@ server's OpenCL/api-docs repository.
<command name="clSetKernelExecInfoARM"/>
</require>
</extension>
<extension name="cl_arm_get_core_id" revision="0.0.0" condition="defined(CL_VERSION_1_2)" supported="opencl">
<extension name="cl_arm_get_core_id" revision="0.0.0" depends="CL_VERSION_1_2" supported="opencl">
<require>
<type name="CL/cl.h"/>
</require>
Expand Down Expand Up @@ -7286,7 +7286,7 @@ server's OpenCL/api-docs repository.
<command name="clEnqueueWriteHostPipeINTEL"/>
</require>
</extension>
<extension name="cl_ext_image_requirements_info" revision="0.5.0" depends="CL_VERSION_3_0" condition="defined(CL_VERSION_3_0)" supported="opencl">
<extension name="cl_ext_image_requirements_info" revision="0.5.0" depends="CL_VERSION_3_0" supported="opencl">
<require comment="Types">
<type name="cl_image_requirements_info_ext"/>
</require>
Expand Down Expand Up @@ -7377,7 +7377,7 @@ server's OpenCL/api-docs repository.
<command name="clGetMutableCommandInfoKHR"/>
</require>
</extension>
<extension name="cl_ext_image_from_buffer" revision="1.0.0" depends="CL_VERSION_3_0+cl_ext_image_requirements_info" condition="defined(CL_VERSION_3_0)" supported="opencl">
<extension name="cl_ext_image_from_buffer" revision="1.0.0" depends="CL_VERSION_3_0+cl_ext_image_requirements_info" supported="opencl">
<require comment="cl_image_requirements_info_ext">
<enum name="CL_IMAGE_REQUIREMENTS_SLICE_PITCH_ALIGNMENT_EXT"/>
</require>
Expand Down
2 changes: 0 additions & 2 deletions xml/registry.rnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ Extensions = element extensions {
# author - name of the author (usually a company or project name)
# contact - contact responsible for the tag (name and contact information)
# type - 'device' or 'instance', if present
# condition - C preprocessor expression (**TBD**)
# depends - boolean expression of API and/or extension names
# upon which this extension depends.
# supported - comma-separated list of API name(s) supporting this extension,
Expand Down Expand Up @@ -487,7 +486,6 @@ Extension = element extension {
attribute author { text } ? ,
attribute contact { text } ? ,
attribute type { text } ? ,
attribute condition { text } ? ,
attribute depends { text } ?,
attribute supported { StringGroup } ? ,
attribute ratified { text } ? ,
Expand Down