Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up cl_khr_create_command_queue #1138

Merged

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Apr 3, 2024

Removes unneeded special-case text regarding the type accepted for CL_QUEUE_PROPERTIES. Calling this a cl_bitfield was a bug all along, and using cl_command_queue_properties is fine because it is a bitfield anyhow.

Generalizes some text so it is not specific to OpenCL 2.x devices.

Removes a TODO - no changes required.

Removes unneeded special-case text regarding the type accepted for
CL_QUEUE_PROPERTIES.  Calling this a cl_bitfield was a bug all
along, and using cl_command_queue_properties is fine because it is
a bitfield anyhow.

Generalizes some text so it is not specific to OpenCL 2.x devices.

Removes a TODO - no changes required.
@bashbaug bashbaug requested a review from alycm April 3, 2024 05:11
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree that describing legacy aliases to cl_bitfield isn't worthwhile.

@alycm
Copy link
Contributor

alycm commented Apr 4, 2024

CLA bot hasn't run, already documented in #1128, there are no CLA issues with this PR, merging.

@alycm alycm merged commit 49a8bd8 into KhronosGroup:main Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants