Clarify Acquire/Release behavior for external memory #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good generally. |
kpet
reviewed
May 28, 2024
bcalidas
reviewed
May 31, 2024
api/opencl_runtime_layer.asciidoc
Outdated
| that was one of the devices specified via {CL_MEM_DEVICE_HANDLE_LIST_KHR} | ||
| when the memory object was imported using {clCreateBufferWithProperties} or | ||
| {clCreateImageWithProperties}. If {CL_MEM_DEVICE_HANDLE_LIST_KHR} was not | ||
| specified, the acquire can be performed on a command-queue associated with |
There was a problem hiding this comment.
The release can be performed on a command queue ...
Address some of the comments that were left out in earlier update.
kpet
reviewed
Jul 10, 2024
| The following restrictions shall apply - | ||
| * Each memory object must be released only once. Releasing a memory object | ||
| multiple times without acquiring it results in implementation-defined | ||
| behavior. |
There was a problem hiding this comment.
Strictly speaking this is ambiguous (and so is the mirror statement above for acquire operations). There might be a better formulation, possibly describing this in terms of number of acquire/release operations but the current text is a clear step forward so fine if you want to merge it as is.
Fix the typo suggested by Kevin to replace aquired to acquired. Co-authored-by: Kévin Petit <kevin.petit@arm.com>
bashbaug
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify Acquire/Release behavior for external memory specs to call out the scope of operations as well as
the behavior in case of multiple acquire/release calls.
Fixes #1078, #1086