Update generated headers and remove CL/GL types from cl_platform.h #257
Conversation
There was a problem hiding this comment.
I'm OK with this and I think it's the right thing to do, but cl_gl.h is currently generated, so if we merge this as-is we'll need to be careful not to overwrite this change next time we re-generate headers.
If possible, I think it would be preferable to:
- Make this change to cl.xml first, either as part of #960 or separately, if it'll take some time for #960 to land.
- Regenerate headers with the updated XML file to update cl_gl.h.
Would this be OK? I'll happily review and merge a PR for (1) as soon as it's ready. Thanks!
- Move CL/GL type declarations from cl_platform.h to cl_gl.h - Include version macros for extensions Signed-off-by: Kevin Petit <kevin.petit@arm.com>
kpet
changed the title
|
Oh yes, you're right. The few seconds I spent observing the absence of a mako template for I've created a PR (KhronosGroup/OpenCL-Docs#1210) separate from KhronosGroup/OpenCL-Docs#960 (that I agree will likely require a bit more discussion) and repurposed this one to update the generated headers and manually remove the types from |
|
I think this should be fairly non-contentious, so I'm going to go ahead and merge this offline. |
Signed-off-by: Kevin Petit kevin.petit@arm.com