Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello_xr: add debug output for Vulkan extensions from runtime vs. app #403

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

T-X
Copy link
Contributor

@T-X T-X commented Apr 28, 2023

Adding some extra debug output when "--verbose --graphics Vulkan(2)" is specified, to list which Vulkan instance and Vulkan device extensions were requested by the XR runtime and which were requested by the application.

I found this quite useful to have to get the current wineopenxr implementation running without Steam. Steam uses Windows registry keys at the moment to relay Vulkan extensions needed by the XR runtime to DXVK. Without Steam I need to populate the registry keys manually at the moment.

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2023

CLA assistant check
All committers have signed the CLA.

@rpavlik-bot
Copy link
Collaborator

An issue (number 2018) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2018 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rpavlik rpavlik force-pushed the pr-vulkan-extensions-debug-output branch from 2dccb4b to ca02a62 Compare September 23, 2024 15:30
Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and sorry for the delay! I made a few very minor changes, added a changelog fragment, and will merge this.

@rpavlik rpavlik force-pushed the pr-vulkan-extensions-debug-output branch from ca02a62 to e6d50de Compare September 23, 2024 15:31
@rpavlik rpavlik enabled auto-merge (rebase) September 23, 2024 15:31
@rpavlik rpavlik self-assigned this Sep 23, 2024
Adding some extra debug output when "--verbose --graphics Vulkan(2)" is
specified, to list which Vulkan instance and Vulkan device extensions
were requested by the XR runtime and which were requested by the
application.

I found this quite useful to have to get the current wineopenxr
implementation running without Steam. Steam uses Windows
registry keys at the moment to relay Vulkan extensions needed by the XR
runtime to DXVK. Without Steam I need to populate the registry keys
manually at the moment.

Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Reviewed-by: Rylie Pavlik <rylie.pavlik@collabora.com>
@rpavlik rpavlik merged commit 2c9b058 into KhronosGroup:main Sep 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants