hello xr: change the ViewConfigurationType #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the ViewConfigurationType which app expected but runtime not supported to the one the runtime prefers the application to use.
jypeitao
force-pushed
the
change_ViewConfigurationType
branch
from
cab41aa
to
fc63fec
Compare
|
An issue (number 2258) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2258 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
|
I think ideally we'd just have it as a command line option. In this case, the app is flexible enough to support just about any view config, but this is intended to be a two-step interaction in general: app gets the runtime preferences, and chooses the first one on the runtime's list that is also on the app's "known supported" list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ViewConfigurationType which app expected but runtime not supported to the one the runtime prefers the application to use.