Fix defects in vector check_* functions
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `check_as_result` to prevent reading from uninitialized memory for cases where `(N * sizeof(vecType)) < (asN * sizeof(asType))`. Also, change its return type to `bool` to match its definition. Fix `check_convert_as_all_dims` and `check_convert_as_all_types` to combine `check_*` results using the `&=` operator rather than the `+=` operator. This change is consistent with the definition of `check_vector_convert_modes`. Fix `check_vector_convert_result` to use the `rte` or `rtz` conversion functions when the `mode` is `rounding_mode::automatic`. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
bader
reviewed
Jul 21, 2023
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
gmlueck
added a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Jul 25, 2023
This change was prompted by a discussion in KhronosGroup/SYCL-CTS#756, relating to a test of `vec::as`. That test tried to use `vec::as` to reinterpret a `sycl::vec<float, 3>` as `sycl::vec<int, 4>`, which is legal according to the spec because they both have the same storage size. (This is because a `vec` of length 3 has the same storage size as a `vec` of length 4.) However, the semantics are unclear because the content of the 4th element is undefined for a 3 element `vec`. It seems reasonable to simply state that such a use of `vec::as` is not allowed. I think our intent was to allow `vec::as` to reinterpret only the bits of defined elements in a `vec`, which is what this change does.
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
bader
approved these changes
Jul 25, 2023
gmlueck
approved these changes
Jul 25, 2023
|
another reviewer please |
ProGTX
approved these changes
Aug 1, 2023
keryell
added a commit
to KhronosGroup/SYCL-Docs
that referenced
this pull request
Aug 17, 2023
This change was prompted by a discussion in KhronosGroup/SYCL-CTS#756, relating to a test of `vec::as`. That test tried to use `vec::as` to reinterpret a `sycl::vec<float, 3>` as `sycl::vec<int, 4>`, which is legal according to the spec because they both have the same storage size. (This is because a `vec` of length 3 has the same storage size as a `vec` of length 4.) However, the semantics are unclear because the content of the 4th element is undefined for a 3 element `vec`. It seems reasonable to simply state that such a use of `vec::as` is not allowed. I think our intent was to allow `vec::as` to reinterpret only the bits of defined elements in a `vec`, which is what this change does.
keryell
added a commit
to KhronosGroup/SYCL-Docs
that referenced
this pull request
Sep 10, 2024
This change was prompted by a discussion in KhronosGroup/SYCL-CTS#756, relating to a test of `vec::as`. That test tried to use `vec::as` to reinterpret a `sycl::vec<float, 3>` as `sycl::vec<int, 4>`, which is legal according to the spec because they both have the same storage size. (This is because a `vec` of length 3 has the same storage size as a `vec` of length 4.) However, the semantics are unclear because the content of the 4th element is undefined for a 3 element `vec`. It seems reasonable to simply state that such a use of `vec::as` is not allowed. I think our intent was to allow `vec::as` to reinterpret only the bits of defined elements in a `vec`, which is what this change does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the return type of
check_as_resulttoboolto match its definition.Fix
check_convert_as_all_dimsandcheck_convert_as_all_typesto combinecheck_*results using the&=operator rather than the+=operator. This change is consistent with the definition ofcheck_vector_convert_modes.Fix
check_vector_convert_resultto use therteorrtzconversion functions when themodeisrounding_mode::automatic.