Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool check on generic accessor api #757

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Fix bool check on generic accessor api #757

merged 3 commits into from
Jul 27, 2023

Conversation

jiezzhang
Copy link
Contributor

Replace the first AND assignment with assignment because res is initialized as false.

@jiezzhang jiezzhang requested a review from a team as a code owner July 25, 2023 06:37
keryell
keryell approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bader bader merged commit 580a907 into KhronosGroup:SYCL-2020 Jul 27, 2023
8 checks passed
@maarquitos14
Copy link
Contributor

res_acc is being changed in test_accessor_ptr_device, so this change is dismissing the results from that function. I think this PR should be reverted.

@maarquitos14 maarquitos14 mentioned this pull request Jul 27, 2023
Merged
@bader
Copy link
Contributor

bader commented Jul 27, 2023

res_acc is being changed in test_accessor_ptr_device, so this change is dismissing the results from that function. I think this PR should be reverted.

Good eye. I missed the use of res_acc by test_accessor_ptr_device.

@bader bader mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@keryell keryell keryell approved these changes

@TApplencourt TApplencourt TApplencourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiezzhang @maarquitos14 @bader @keryell @TApplencourt