[NFC] Refactor kernel_compiler_spirv tests #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the test to load the SPIR-V module files using CMake instead of `std::ifstream`. This change makes the test binary more portable since it now contains the required SPIR-V modules. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
keryell
reviewed
Apr 19, 2024
tests/extension/oneapi_kernel_compiler_spirv/kernel_compiler_spirv.cpp
Outdated
Show resolved
Hide resolved
|
@0x12CC Ping. |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
|
Sorry for the delay, @keryell. I was just trying to catch up on some tasks and I've addressed your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the test to load the SPIR-V module files using CMake instead of
std::ifstream. This change makes the test binary more portable since it now contains the required SPIR-V modules.