Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up vector_swizzle tests into smaller chunks to improve compilation times #901

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

lbushi25
Copy link
Contributor

The vector swizzle tests are failing to compile on machines with 16 GB of RAM due to the huge size of some of the test .cpp files that are generated by the scripts. This PR makes the necessary changes to enforce splitting of these test files into smaller and more manageable files that can be compiled without requiring a large memory footprint. As of the time of this writing, I've chosen the number of batches aka chunks to be 32 so that each large file will be subdivided into 32 smaller files. I chose this number because with 16 chunks I was seeing flaky results where a compilation would succeed or fail depending on the state of the machine at the time of compilation. With 32 however, compilation was succeeding constantly. Nevertheless, this can easily be adjusted according to our needs.

@lbushi25 lbushi25 requested a review from a team as a code owner June 13, 2024 06:15
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Your PR description is an interesting design argumentation which should appear somewhere in some comments to avoid being lost.

tests/common/common_python_vec.py Show resolved Hide resolved
@bader bader merged commit 2e439a7 into KhronosGroup:SYCL-2020 Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants