-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update to header 1.3.293 #1536
Conversation
CI Vulkan-Loader build # 2665 failed. |
1 similar comment
CI Vulkan-Loader build # 2665 failed. |
So this is fun This bit of xml broke the extension code generator I thought I was being clever and converted the xml expression to a C expression But only now do I realize that |
Well not to put too fine of a point, but this does expose a bug in the codegen - it doesn't handle the requires expressions nor multiple requires blocks. Which, isn't a bad thing. |
CI Vulkan-Loader build queued with queue ID 237137. |
CI Vulkan-Loader build # 2666 running. |
CI Vulkan-Loader build # 2666 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
loader_extension_generator.py needed a tweak to handle boolean logic in the vk.xml extension dependency attributes. Now that the dependency is encoded in vk.xml we don't need to manually turn on device_group for drivers >= 1.1. We DO need to track the driver api version since the xml expressions references it.
74a8fbb
to
dad9b69
Compare
CI Vulkan-Loader build queued with queue ID 237164. |
1 similar comment
CI Vulkan-Loader build queued with queue ID 237164. |
squashed before merging |
loader_extension_generator.py needed a tweak to handle boolean logic in the vk.xml extension dependency attributes