Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to header 1.3.293 #1536

Merged
merged 1 commit into from
Aug 16, 2024
Merged

build: Update to header 1.3.293 #1536

merged 1 commit into from
Aug 16, 2024

Conversation

mikes-lunarg
Copy link
Collaborator

loader_extension_generator.py needed a tweak to handle boolean logic in the vk.xml extension dependency attributes

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2665 failed.

1 similar comment
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2665 failed.

@mikes-lunarg
Copy link
Collaborator Author

mikes-lunarg commented Aug 16, 2024

So this is fun

This bit of xml broke the extension code generator
KhronosGroup/Vulkan-Headers@d205aff#diff-a852a94832433f254f7e5ff6cf889035be373606623d793dfe4a75e535600cbeL20518-L20521

I thought I was being clever and converted the xml expression to a C expression
https://github.com/KhronosGroup/Vulkan-Loader/pull/1536/files#diff-0a4c13d93f077e821b16b5ad1e98275bb1ef50f7bd9876418d7f955600943527L1503

But only now do I realize that dev->driver_extensions.version_1_1_enabled doesn't exist, because dev->driver_extensions.device_group_enabled gets implicitly turned on for api version >= 1.1

@charles-lunarg
Copy link
Collaborator

Well not to put too fine of a point, but this does expose a bug in the codegen - it doesn't handle the requires expressions nor multiple requires blocks. Which, isn't a bad thing.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 237137.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2666 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2666 passed.

Copy link
Collaborator

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

loader_extension_generator.py needed a tweak to handle boolean logic in
the vk.xml extension dependency attributes.  Now that the dependency is
encoded in vk.xml we don't need to manually turn on device_group for
drivers >= 1.1. We DO need to track the driver api version since the xml
expressions references it.
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 237164.

1 similar comment
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 237164.

@mikes-lunarg
Copy link
Collaborator Author

squashed before merging

@mikes-lunarg mikes-lunarg merged commit 2804c25 into main Aug 16, 2024
83 checks passed
@mikes-lunarg mikes-lunarg deleted the __release-1.3.293 branch August 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants