Fix twocall_chain_vectors mechanism #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of unconditionally querying properties twice, only call the query again if the given output struct has array members. Also fix the case where if there are no output structs with array properties (VulkanSC), then don't end up with unresolved external symbols.
|
|
charles-lunarg
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VulkanSC found that the twocall machinery makes the assumption that there is at least one property output struct with array members. While this breaks VulkanSC (results in unresolved external symbol), it also breaks Vulkan when used with older
vk.xmlfiles where this assumption may also not hold true. Also, instead of unconditionally querying properties twice, only call the query again if the given output struct has array members.Note: the current refinement is still "happens to work" territory, as a generic solution would need to do
ncalls to query, depending on the number of nesting of structs with array members.twocallworks today but may break tomorrow.