vulkaninfo: Correctly query per-surface queue support #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Tools build queued with queue ID 266499. |
|
CI Vulkan-Tools build # 1527 running. |
|
CI Vulkan-Tools build # 1527 passed. |
ziga-lunarg
reviewed
Sep 27, 2024
Previous implementation would always run the function 3 times no matter what.
The previous implementation did not differentiate when a single queue supported a specific surface. It will now print 'true' if all surfaces support presentation with a queue, 'false' if none, and otherwise prints each surface type's support if they aren't uniform in value. This makes the info regarding which queue supports presentation on a surface much easier to validate the correctness of.
charles-lunarg
force-pushed
the
vulkaninfo_work
branch
from
ec0f6f6
to
aad3d0d
Compare
|
CI Vulkan-Tools build queued with queue ID 266546. |
|
CI Vulkan-Tools build # 1528 running. |
ziga-lunarg
approved these changes
Sep 27, 2024
|
CI Vulkan-Tools build # 1528 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus other small improvements.