cube: Check in SPIRV code #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shader code used by vkcube & vkcubepp is now checked into the source. This prevents users from needing a version of glslang on the system in order to build the project. While the existing mechanism of fetching a glslang binary from github was adequate, the version used linked to VS 2013 which caused build failures with rather cryptic linker errors. Since changing the shaders happens very infrequently, the decision has been made to check in the spir-v code. The CMake logic to compile the shaders remainds, but is put behind a new build flag COMPILE_CUBE_SHADERS.
|
CI Vulkan-Tools build queued with queue ID 45131. |
|
CI Vulkan-Tools build # 1131 running. |
|
CI Vulkan-Tools build # 1131 passed. |
juan-lunarg
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shader code used by vkcube & vkcubepp is now checked into the source. This prevents users from needing a version of glslang on the system in order to build the project. While the existing mechanism of fetching a glslang binary from github was adequate, the version used linked to VS 2013 which caused build failures with rather cryptic linker errors. Since changing the shaders happens very infrequently, the decision has been made to check in the spir-v code.
The CMake logic to compile the shaders remainds, but is put behind a new build flag COMPILE_CUBE_SHADERS.