Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

SoC PolarFire: Add footprints for 484 & 1152 BGA #2489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pthomas
Copy link

@pthomas pthomas commented Sep 24, 2020

On both parts a Solder mask clearance of 0.015mm is defined per
the packaging guide.

Both were generated with the Ball Grid Array Footprint Wizard

These footprints are defined here:
https://www.microsemi.com/document-portal/doc_download/1244577-ug0902-polarfire-soc-fpga-packaging-and-pin-descriptions-user-guide


These are the two packages Microchip has provided for the PolarFire SoC's, the symbol pull request can be viewed here:
KiCad/kicad-symbols#2843

⚠️ Deprecation warning

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage
Copy link
Collaborator

@pthomas a screenshot is always very nice to start the review, as requested in the PR template.

By the way, have you scripted the footprint ? You should. Post a link here to the generator PR if it was done.

Joel

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer Scripting required A scripted version of this contribution is required labels Sep 25, 2020
@pthomas
Copy link
Author

pthomas commented Sep 25, 2020 via email

@myfreescalewebpage
Copy link
Collaborator

@chschlue following comment "The footprints were just made with the built-in 'Ball Grid Array Footprint Wizard'.", is it the correct way to generate BGA fp ? Thanks

@chschlue
Copy link
Contributor

@myfreescalewebpage
Copy link
Collaborator

Thanks @chschlue
@pthomas you should use the generator indicated above.

@pthomas
Copy link
Author

pthomas commented Sep 28, 2020 via email

@myfreescalewebpage
Copy link
Collaborator

You should submit a pull request on the footprint generator git and update this PR with the generated footprint.
The generator is not integrated in KiCad, but maybe one day, who knows ? :)

@chschlue
Copy link
Contributor

chschlue commented Sep 28, 2020

So should I submit a pull request against bga.yaml?

Yes, please.

It might be nice if the preferred tool were the one actually included in kicad?

Theoretically yes, and the generator is going to become part of the KiCad project instead of being a third party repo, but actually including it in the application is not quite so easy, we would still need some procedure to add size definitions to the repo for example.

Note that the two generators work differently. The one internal to KiCad lets you directly specify a footprint you desire (arranging pads in arrays and such in the process) while the one used for library additions lets you specify a package, auto-generating IPC 7351 compliant footprints for it. This means the latter is vastly superior for creating general purpose footprints for use in an included library.

@pthomas
Copy link
Author

pthomas commented Sep 29, 2020 via email

@myfreescalewebpage
Copy link
Collaborator

@pthomas adding the footprint here at the same time is also a great benefit for the reviewer...

@pthomas
Copy link
Author

pthomas commented Sep 30, 2020 via email

@myfreescalewebpage
Copy link
Collaborator

I think it's not bad, but just to be sure: you have not to rename the parts. You should push here the exact result of the script.

@pthomas
Copy link
Author

pthomas commented Oct 1, 2020 via email

@myfreescalewebpage myfreescalewebpage removed the Scripting required A scripted version of this contribution is required label Oct 1, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Oct 1, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Oct 1, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Oct 1, 2020

@pthomas one question here:

  • Why "Microchip_FCVG484_19x19mm_Layout22x22_P0.8mm" is called "Microchip_FCVG484_11x11mm_Layout22x22_P0.8mm" here ? (package size 11 != 19mm)

Joel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants