Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Chip molded footprint cleanup #2495

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Conversation

evanshultz
Copy link
Collaborator

From pointhi/kicad-footprint-generator#438 (comment). @cpresser I'm pinging you since you will know what and why without we writing things down here again in detail. And my commit messages should be clear as well.


⚠️ Deprecation warning

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@cpresser
Copy link
Contributor

Just a short ping from me that I have seen this PR.
I am lacking motivation to do this right now, but will see to it shortly.

@evanshultz
Copy link
Collaborator Author

@cpresser
Will it be possible to get this in before the cutoff? Is there something else I should do to help?

@cpresser cpresser merged commit 73a12d2 into KiCad:master Oct 1, 2020
@cpresser
Copy link
Contributor

cpresser commented Oct 1, 2020

@cpresser
Will it be possible to get this in before the cutoff? Is there something else I should do to help?

I wanted to get the generator merged first. But I lost track of generator changes, so I have to (at least partially) start over. Finding motivation for that is hard, its a huge, overwhelming change-set.

@evanshultz evanshultz deleted the chip-molded-cleanup branch October 1, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants