Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

WDC65C816S 8/16-bit microprocessor DIP-40 #2780

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

na-g
Copy link

@na-g na-g commented Jun 4, 2020

WDC65C816S 8/16-bit static microprocessor DIP-40 package
Data sheet: http://archive.6502.org/datasheets/wdc_w65c816s_oct_11_2018.pdf
Screen shot:WDC65C816S-03 (updated)

This conforms somewhat to the layout of the COMMODORE 6502 in obsolete/CPU, though a few pins needed to be regrouped for address validation (VPA,VPD,RW, and PHI2). The 65C816S has no NC pins, and it only has a single VSS and VDD.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing

  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible

  • Ensure that the associated footprints match the official footprint library

    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate

  • Check the output of the Travis automated check scripts - fix any errors as required

  • Give a reason behind any intentional library convention rule violation.


Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2020

CLA assistant check
All committers have signed the CLA.

@na-g na-g marked this pull request as draft June 4, 2020 09:57
@na-g na-g marked this pull request as ready for review June 4, 2020 11:11
@na-g
Copy link
Author

na-g commented Jun 5, 2020

This is my first part submission, and I would rather like this to be a high quality symbol. I plan on submitting the WDC65C02S static 65C02, interface adapter, and serial adapter. So I would like to get things correct now.

I have some questions for the reviewer:

  1. Other packages are available, though I am don't believe them to be commonly used in the retro community. I am not opposed to adding them, if necessary. If that is the case, do they all need to be done in the same commit, or can they be split into multiple commits?

  2. ϕ2 in some of the 68C816 literature it is an uppercase Greek phi, in this particular data sheet it is PHI2. I used the character for brevity. I noticed the Commodore 6502 part uses a Dutch zero for its clock ports. I would like to do whatever is considered clear, concise, and conventional.

  3. The data pins are tri-state buffers, like the 6502. The symbol for the 6502 has them marked as bi-directional not tri-state. I initially used bi-directional to match the 6502. Is there a convention here that I am not aware of, or is that an oversight in the 6502 symbol?

  4. The top 8-bits of the address bus are multiplexed onto the data bus. If there is a better convention around the naming or arrangement let me know. They could be moved to below the address pins, but for now they roughly match the 6502 part.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 5, 2020
@ghost
Copy link

ghost commented Aug 3, 2020

Hi, and thanks for you first submission 🎉

Some answers:

  1. No, it is not mandatory to include all variants. They can be added in different Pull-requests.
  2. There is no explicit written rule for which characters are allowed (but a similar one: https://kicad-pcb.org/libraries/klc/G1.1/) I would prefer to see PHI2 here. The KLC also states that the pin-name needs to be exactly the same as in the datasheet.
  3. There is rule S4.4 (https://kicad-pcb.org/libraries/klc/S4.4/). Those pins here are not really programmable, so bidir does not apply. Tri-state seems to be fine at first glance. The reason we have pin-types is mostly ERC. So look at it from an ERC perspective. Think of which other pin-types will be connected to them and if that would generate an error. For example, adding an output-pin to a net with a tri-state-pin seems wrong and should at least generate a ERC warning.
  4. No clue. I don't understand the multiplexim scheme here. Can you elaborate, or point me to the correct page in the datasheet?

@na-g
Copy link
Author

na-g commented Aug 19, 2020

@cp-aquila thanks for your feedback!

@myfreescalewebpage myfreescalewebpage self-assigned this Aug 23, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 23, 2020
@myfreescalewebpage
Copy link
Collaborator

Hi @na-g , thanks for contributing,

A few comments I have during my review:

  • Name should be "65C816S_DIP40" to handle future other variants of the symbol
  • Description should ends with package name: "8/16 Bit Microprocessor, DIP-40"
  • To avoid issue with specific symbol, name of pin 37 should be "PHI2"

This is a very good contribution :)

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

@na-g ping, please check my previous comment

@na-g
Copy link
Author

na-g commented Sep 2, 2020

@myfreescalewebpage , thank you for your review! I haven't had time to work on this; I'll get to it this weekend. Then, I will close it as a duplicate of #2862 which is a superset of this work. This can be reopened if #2862 doesn't land, for some unforeseeable reason. Thanks again for the guidance, it will be useful for future contributions as well.

@myfreescalewebpage
Copy link
Collaborator

@na-g thanks for the answer, will review again after the changes

@myfreescalewebpage
Copy link
Collaborator

@na-g #2862 has been closed by the contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants