Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added a set of common generic relays #2787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osholt
Copy link

@osholt osholt commented Jun 6, 2020

I added generic relays to device library of the following popular configurations:
Relay_DPDT
image
Relay_DPST_NC
image
Relay_DPST_NO
image
Relay_SPDT
image
Relay_SPST_NC
image
Relay_SPST_NO
image

All symbols are consistent with the fully specified relays used in the relays library. Generic relays encounter similar problems to generic op amps regarding pin numbering: every package and every manufacturer uses different conventions. I picked a simple convention to follow in line with generic op amps.

All symbols were tested with the checklib.py script and comply with all KLC guidelines applicable to generic parts.

I have not included any latching relays but I (or someone else) may do this in the future.

As this is a generic library contribution I have not included any specific datasheet or footprint information.

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

I added generic relays to device library of the following popular configurations:
Relay_DPDT
Relay_DPST_NC
Relay_DPST_NO
Relay_SPDT
Relay_SPST_NC
Relay_SPST_NO

All symbols are consistent with the fully specified relays used in the relays library.  Generic relays encounter similar problems to generic op amps regarding pin numbering: every package and every manufactuer uses different conventions. I picked a simple convention to follow in line with generic op amps.

All symbols were tested with the checklib.py script and comply with all KLC guidelines applicable to generic parts.

I have not included any latching relays but I (or someone else) may do this in the future.
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 7, 2020
@myfreescalewebpage
Copy link
Collaborator

@osholt thanks for this contribution.
However, I'm not sure it's really wanted because you are showing a specific configuration of pins and all relays do not have the same pin assignment. @evanshultz your point of view ? Maybe something we should define with generic pin name ?
Joel

@osholt
Copy link
Author

osholt commented Sep 6, 2020

@osholt thanks for this contribution.
However, I'm not sure it's really wanted because you are showing a specific configuration of pins and all relays do not have the same pin assignment. @evanshultz your point of view ? Maybe something we should define with generic pin name ?
Joel

Thanks for taking the time to review! I am happy to call the pins whatever works.

The precedent for transistors of including every pin permutation I did not think was appropriate as relay pin allocations are far from standardised between packages or manufacturers but the functions are highly standardised.

I created them because I was frustrated by a lack of generic relays to include in the design stage before having to commit to a specific part.

There are certainly other generic parts that struggle from the same "generic function but no generic pin number problem" and I am not sure how they have been handled: coupled inductors, multi-tap transformers and and generic op-amps come to mind.

Oliver

@myfreescalewebpage
Copy link
Collaborator

@chschlue also maybe your point of vieww (my comment at #2787 (comment))

@chschlue
Copy link
Contributor

I'm generally in favor of the numbering suggested in #2705 (comment), but I'm not quite sure if that's understood internationally, especially across the pond.
@evanshultz?

@myfreescalewebpage
Copy link
Collaborator

I agree

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants