Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added ARJM11D7-114-AB-EW2 #2816

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Misaka0x2730
Copy link
Contributor

@Misaka0x2730 Misaka0x2730 commented Jun 21, 2020

Added ARJM11D7-114-AB-EW2 - Single port 100Base-T connector with PoE.
https://abracon.com/Magnetics/ARJM11.pdf
image

Footprint PR: KiCad/kicad-footprints#2325

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 25, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 25, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 25, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 25, 2020

Hi @Misaka0x2730 , thanks for contributing,

A few comments I have during my review:

  • Name of the symbol should be RJ45_Abracon_ARJM11D7-114-AB
  • Footprint should be Connector_RJ:RJ45_Abracon_ARJM11D7-114-AB
  • Pin offset: 20mil

Else just need to wait the integration of the footprint.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 25, 2020
@myfreescalewebpage
Copy link
Collaborator

Thanks for the update, just need to wait the footprint now.

@cpresser
Copy link
Contributor

cpresser commented Sep 8, 2020

This looks similar to Connector_RJ:RJ45_Abracon_ARJP11A-MA_Horizontal? Is it based on that symbol?
image

It would be nice if the two symbols are as interchangeable as possible. Meaning pins with similar functions should be at the same position. For example the TD+ and TD- pair (same for RD).

@Misaka0x2730
Copy link
Contributor Author

@cpresser Yes, it's based on ARJP11 symbol, but IMHO, this is not very critical.

@myfreescalewebpage
Copy link
Collaborator

Will be a little bit difficult because there is more pins and drawing inside, but maybe one day we will be able to enhance all the RJ45 parts. We need more parts to have a better view of the possibilities I think.

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants