Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

RF_Filter - 1090MHz SAW filters 8-pin STA1090EC/MP08167, and 6-pin ST… #2868

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RF_Filter - 1090MHz SAW filters 8-pin STA1090EC/MP08167, and 6-pin ST… #2868

wants to merge 3 commits into from

Conversation

chmorgan
Copy link
Collaborator

@chmorgan chmorgan commented Jul 19, 2020

Add SAW filter symbols

Footprint pull request:
KiCad/kicad-footprints#2366

image
https://www.golledge.com/media/3785/mp08167.pdf

image
https://www.golledge.com/media/1831/ma05497.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@aewallin
Copy link
Contributor

aewallin commented Jul 19, 2020

  • if you search for "bandpass" in the current existing symbols you will find they all use more or less the same symbol, is there any reason not to use that one here also?
  • I would include 'bandpass' in the description and/or keywords
  • GND pins should be named GND and stacked?
  • for the balanced input, is there a preferred direction for the pins? should they be named +/- or IN and ~IN or similar?
  • description should end with the (simplified) footprint name

(I am not a reviewer, just commenting from the sidelines..)

@chmorgan
Copy link
Collaborator Author

Hi @aewallin.

For not a reviewer this is good stuff!

  • Good idea on bandpass, the datasheets do describe them as bandpass filters as that's what they do.
  • None of the existing symbols have the correct pinout but their symbols do make sense for these SAW filters. I'll update to use the same shape.
  • Correct on the ground pins and stacking, I'll fix that as well.
  • There is nothing mentioned on the data sheets about how to connect the balanced inputs. Maybe IN_1 and IN_2 is ok?
  • What would the footprint name be then?

Chris

@chmorgan
Copy link
Collaborator Author

@aewallin, updates pushed and screenshots above updated.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Jul 21, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Jul 21, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jul 21, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jul 21, 2020

Hi @chmorgan , thanks for contributing, and thanks to @aewallin for the first review

A few comments I have during my review:

  • Footprint filter: Filter*SAW*3.8x3.8mm*
  • I agree with the alias, but I don't see the where the name of the symbol come from... ? Where STA0232A and STA1090EC come from ? Have you got a datasheet ?

Cheers,
Joel

@chmorgan
Copy link
Collaborator Author

Hi @myfreescalewebpage, for whatever reason Sawtron doesn't have datasheets for their parts online although they've sent me the datasheets upon request for info about those parts. Equivalent Golledge part datasheets (which are aliases), are the ones I've cited but I'm not sure how to cite data sheets for parts that I can't find on the web. The STA1090EC and STA0232A are quite popular and used all over avionics circuits too...

@myfreescalewebpage
Copy link
Collaborator

Thanks for the detail. I suggest to remove the datasheet link for the STA devices in this case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants