Trap for URI format exceptions when unescaping URLs. Use raw base val…

…ue in the event of errors.
Kinematics · Jun 11, 2017 · ccd491a · ccd491a
1 parent 91a74cb
commit ccd491a
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/NetTally.Core/Input/Forums/PostText.cs b/NetTally.Core/Input/Forums/PostText.cs
@@ -195,14 +195,23 @@ private static StringBuilder ExtractPostTextString(HtmlNode node, Predicate<Html
                         if (child.GetAttributeValue("class", "").Contains("mceSmilieSprite"))
                             break;
 
+                        string imgHref = srcUrl;
+
                         if (!string.IsNullOrEmpty(srcUrl))
                         {
-                            // If the source URL is relative, prepend the forum's host.
-                            // This will not modify absolute URLs.
-                            Uri absoluteSrc = new Uri(host, Uri.UnescapeDataString(srcUrl));
-
-                            sb.Append($"『url=\"{absoluteSrc.ToString()}\"』<Image>『/url』");
+                            try
+                            {
+                                // If the source URL is relative, prepend the forum's host.
+                                // This will not modify absolute URLs.
+                                Uri absoluteSrc = new Uri(host, Uri.UnescapeDataString(srcUrl));
+                                imgHref = absoluteSrc.ToString();
+                            }
+                            catch (UriFormatException)
+                            {
+                            }
                         }
+
+                        sb.Append($"『url=\"{imgHref}\"』<Image>『/url』");
                         break;
                     case "div":
                         // Recurse into divs (typically spoilers).