Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.0 / 2023-11-03 #30

Merged
merged 1 commit into from
Nov 29, 2023
Merged

5.0.0 / 2023-11-03 #30

merged 1 commit into from
Nov 29, 2023

Conversation

halostatue
Copy link
Member

@halostatue halostatue commented Oct 12, 2023 •
edited
Loading

  • Upgraded to Python 3.12

  • Upgraded to Ansible 8.5.0

  • Renamed the run script to kineticcafe-ansible and fixed several issues:

    • Bash 4 or later is required for associative array support. Ensured that
      this would be respected on macOS by using /usr/bin/env bash instead of
      /bin/bash.

    • Updated the script to use the current version of the image.

    • Fixed various issues with file and directory mounts. Many more mountable
      files (--become-password-file, etc.) are supported than
      --vault-password-file. Note that not all possible file parameters are
      supported, such as --module-paths or --extra-vars @file. Pull requests
      for supporting these would be considered.

    • Fixed an overzealous application of --ask-vault-password, even for
      commands that could not use it.

    • Changed the sh subcommand to execute bash and added bash as a known
      subcommand.

    • Added support for deriving the entry point from basename $0.

  • Updated the Docker image to use HEREDOC.

    • Added less, nano, and vim-nox packages.

  • Added an install script to install kineticcafe-ansible and optional
    symlinks.

@halostatue halostatue force-pushed the update-and-add-setup-script branch from 8d13cc5 to cc5f068 Compare October 12, 2023 13:31
@halostatue halostatue force-pushed the update-and-add-setup-script branch 2 times, most recently from 2f8ef92 to f48b387 Compare October 30, 2023 17:03
@halostatue halostatue linked an issue Oct 30, 2023 that may be closed by this pull request
README references the wrong docker image #31
Closed
@halostatue halostatue requested review from mikestok and ohnit October 30, 2023 17:11
@halostatue halostatue force-pushed the update-and-add-setup-script branch from 03ac08f to 546b1cb Compare October 30, 2023 17:12
@halostatue halostatue marked this pull request as ready for review October 30, 2023 17:13
@halostatue halostatue self-assigned this Oct 30, 2023
ohnit
ohnit previously approved these changes Oct 30, 2023
View reviewed changes
@halostatue halostatue force-pushed the update-and-add-setup-script branch from 546b1cb to f84393a Compare October 30, 2023 18:17
@halostatue halostatue changed the title 4.1.0 / 2023-10-12 4.1.0 / 2023-10-31 Oct 30, 2023
@halostatue halostatue enabled auto-merge (rebase) October 30, 2023 18:20
@halostatue halostatue disabled auto-merge October 30, 2023 18:22
@halostatue halostatue force-pushed the update-and-add-setup-script branch from f84393a to 34832af Compare October 30, 2023 18:27
mikestok
mikestok reviewed Nov 1, 2023
View reviewed changes
Copy link

@mikestok mikestok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand enough to provide useful comments.

@halostatue halostatue force-pushed the update-and-add-setup-script branch from 34832af to a416fb1 Compare November 2, 2023 04:27
@halostatue
5.0.0 / 2023-11-03
ef03e3d 
- Upgraded to Python 3.12

- Upgraded to Ansible 8.5.0

- Renamed the `run` script to `kineticcafe-ansible` and fixed several issues:

  - Bash 4 or later is required for associative array support. Ensured that
    this would be respected on macOS by using `/usr/bin/env bash` instead of
    `/bin/bash`.

  - Updated the script to use the current version of the image.

  - Fixed various issues with file and directory mounts. Many more mountable
    files (`--become-password-file`, etc.) are supported than
    `--vault-password-file`. Note that not _all_ possible file parameters are
    supported, such as `--module-paths` or `--extra-vars @file`. Pull requests
    for supporting these would be considered.

  - Fixed an overzealous application of `--ask-vault-password`, even for
    commands that could not use it.

  - Changed the `sh` subcommand to execute `bash` and added `bash` as a known
    subcommand.

  - Added support for deriving the entry point from `basename $0`.

- Updated the Docker image to use HEREDOC.

  - Added `less`, `nano`, and `vim-nox` packages.

- Added an `install` script to install `kineticcafe-ansible` and optional
  symlinks.
@halostatue halostatue force-pushed the update-and-add-setup-script branch from a416fb1 to ef03e3d Compare November 2, 2023 04:34
@halostatue halostatue changed the title 4.1.0 / 2023-10-31 5.0.0 / 2023-11-03 Nov 2, 2023
@halostatue halostatue merged commit 0b23928 into main Nov 29, 2023
1 check passed
@halostatue halostatue deleted the update-and-add-setup-script branch November 29, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikestok mikestok mikestok left review comments

@ohnit ohnit ohnit left review comments

Assignees

@halostatue halostatue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README references the wrong docker image
3 participants
@halostatue @mikestok @ohnit