Improved release workflow #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We maintain three docker images:
- ansible
- sqitch / pgTAP
- aws-cli with SessionManager plugin
The release flows are basically the same, but there were *unnecessary*
differences.
- We now no longer conditionally create the release in parallel to the
image build and push. This would result in orphan releases if the
build failed. The release creation is done at the end, immediately before
updating the Dockerhub description.
- We add `annotations` to all metadata configuration.
- We set `env.REPOSITORY` based on `GITHUB_REPOSITORY`, converting entirely to
lowercase and removing the leading `docker-`.
- We use `kineticcafe/${{ env.REPOSITORY }}` for image builds and Dockerhub
description updates.
ohnit
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain three docker images:
The release flows are basically the same, but there were unnecessary
differences.
We now no longer conditionally create the release in parallel to the
image build and push. This would result in orphan releases if the
build failed. The release creation is done at the end, immediately before
updating the Dockerhub description.
We add
annotationsto all metadata configuration.We set
env.REPOSITORYbased onGITHUB_REPOSITORY, converting entirely tolowercase and removing the leading
docker-.We use
kineticcafe/${{ env.REPOSITORY }}for image builds and Dockerhubdescription updates.