Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the point of using php? #11

Open
ArjixWasTaken opened this issue Jul 10, 2024 · 7 comments
Open

What's the point of using php? #11

ArjixWasTaken opened this issue Jul 10, 2024 · 7 comments

Comments

@ArjixWasTaken
Copy link

You are not actually using php, you only have it to split html in multiple files...

@ArjixWasTaken
Copy link
Author

ArjixWasTaken commented Jul 10, 2024

For example, this would be the perfect use of a for-loop in PHP

https://github.com/KirixenYT/Gogoanime/blob/main/anime-list.php#L69-L146

Sure, you do a for-loop for the actual content, but that is because it cannot be done in plain html
https://github.com/KirixenYT/Gogoanime/blob/main/anime-list.php#L149-L161

Also, what the fuck is that php code

<?php
  $json = file_get_contents("$apiLink/animeList?page=$page");
  $json = json_decode($json, true);
  foreach($json as $animeList)  { 
?>
    
    <li title='<?php $desc = $animeList['liTitle']; echo htmlspecialchars($desc);?>'> <a href="/category/<?=$animeList['animeId']?>" title=""><?=$animeList['animeTitle']?></a></li>
<?php } ?>

you could make it easier to read you know

<?php

$json = file_get_contents("$apiLink/animeList?page=$page");
$json = json_decode($json, true);

foreach($json as $animeList)  { ?>
    <li title='<?= htmlspecialchars($animeList['liTitle']) ?>'>
        <a href="/category/<?= $animeList['animeId'] ?>" title=""><?= $animeList['animeTitle'] ?></a>
    </li> <?php
}

@ArjixWasTaken
Copy link
Author

yeah ok I was being mean, sorry about that

@ArjixWasTaken
Copy link
Author

But....I did notice that you are loading the actual analytics scripts from gogocdn...
Did you just copy paste the html from the actual website?

@ruriescaper
Copy link

ruriescaper commented Jul 10, 2024 via email

@ArjixWasTaken
Copy link
Author

so this is a fork?

@ruriescaper
Copy link

ruriescaper commented Jul 10, 2024 via email

@KiriXen
Copy link

KiriXen commented Jul 16, 2024

But....I did notice that you are loading the actual analytics scripts from gogocdn... Did you just copy paste the html from the actual website?

As what @ruriescaper said, I've only updated the website to work properly, and yes it is using the cdn from the actual gogoanime website and I believe the code was also copied from the actual website but with majority updates.. and sorry for the late reply, My github account got locked and I lost the access to it and yeah this is the new account im gonna use from now on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants