Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double-click to open / open from cli #3643

Merged
merged 10 commits into from
Aug 25, 2024
Merged

double-click to open / open from cli #3643

merged 10 commits into from
Aug 25, 2024

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Aug 23, 2024

closes #3577
closes #2362

Copy link

qa-wolf bot commented Aug 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 25, 2024 0:31am

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (4dfad19) to head (c6d10eb).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
- Coverage   87.91%   87.59%   -0.32%     
==========================================
  Files          67       65       -2     
  Lines       26105    25165     -940     
==========================================
- Hits        22950    22044     -906     
+ Misses       3155     3121      -34     
Flag Coverage Δ
wasm-lib 87.59% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz
Copy link
Contributor Author

im so close i just need to figure out the .node files thing vitejs/vite#14289

jessfraz and others added 8 commits August 24, 2024 17:20
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz merged commit 590a647 into main Aug 25, 2024
27 of 28 checks passed
@jessfraz jessfraz deleted the double-click-to-open branch August 25, 2024 00:47
@pierremtb pierremtb mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant