Catch DivisionByZeroError on index.php (#2211)

Fixes #2204
Kitware · May 17, 2024 · c73044c · c73044c
1 parent c1ecdc7
commit c73044c
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/app/cdash/public/api/v1/index.php b/app/cdash/public/api/v1/index.php
@@ -412,11 +412,15 @@
         if ((int) $build_array['loctesteddiff'] > 0) {
             $loctesteddiff = (int) $build_array['loctesteddiff'];
             $locuntesteddiff = (int) $build_array['locuntesteddiff'];
-            @$previouspercent =
-                round(($loctested - $loctesteddiff) /
-                    ($loctested - $loctesteddiff +
-                        $locuntested - $locuntesteddiff)
-                    * 100, 2);
+            try {
+                $previouspercent =
+                    round(($loctested - $loctesteddiff) /
+                        ($loctested - $loctesteddiff +
+                            $locuntested - $locuntesteddiff)
+                        * 100, 2);
+            } catch (\DivisionByZeroError $e) {
+                $previouspercent = 0;
+            }
             $percentdiff = round($percent - $previouspercent, 2);
             $coverage_response['percentagediff'] = $percentdiff;
             $coverage_response['locuntesteddiff'] = $locuntesteddiff;