Bump rustls and tonic version #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why bump |
I'll track this as an issue and let's wait for April! |
|
See fedimint#5 (fedimint fork of this library) for progress on version bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Motivation:
Instead of proposing a migration from rustls to openssl, we this PR proposes a version bump of the two dependencies and then a re-assessment of Issue #17 previously reported. In theory, we should not replicate issue #17 on the latest version of ruslts.
If the issue persists or presents in a different form after the version bump, we should consider patching ruslts, rather than migrate to openssl