Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update atleast 5 landmarks for every city present in cities.json #16

Closed
thenishantsapkota opened this issue Oct 19, 2023 · 5 comments · Fixed by #17
Closed

Update atleast 5 landmarks for every city present in cities.json #16

thenishantsapkota opened this issue Oct 19, 2023 · 5 comments · Fixed by #17
Assignees
@dyaramatreya
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thenishantsapkota
Copy link
Contributor

There should be atleast 5 landmarks for a specified city.
@thenishantsapkota thenishantsapkota added enhancement New feature or request good first issue Good for newcomers labels Oct 19, 2023
@dyaramatreya
Copy link
Contributor

Hi @thenishantsapkota
Do you mean, as a part of the PR we must ensure that the json object at https://github.com/Know-Nepal/borderlines/blob/main/data/borderlines.json contains at least 5 landmarks for each of the already added cities?

@thenishantsapkota
Copy link
Contributor Author

Yes that's exactly my intention, atleast there must be 5 landmarks per city @dyaramatreya

@dyaramatreya
Copy link
Contributor

Ok @thenishantsapkota
Can you pls assign the issue to me?
I'll make the changes and raise a PR

@thenishantsapkota
Copy link
Contributor Author

Assigned it to you @dyaramatreya!

@dyaramatreya dyaramatreya mentioned this issue Oct 20, 2023
Merged
4 tasks
@dyaramatreya
Copy link
Contributor

@thenishantsapkota Linked the PR #17 . Please review and approve the PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyaramatreya dyaramatreya

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(landmarks): added dyaramatreya/borderlines
2 participants
@dyaramatreya @thenishantsapkota