Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landmarks): added #17

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

dyaramatreya
Copy link
Contributor

@dyaramatreya dyaramatreya commented Oct 20, 2023

What kind of change does this PR introduce?

  • This PR updates the json file to make sure every city has at least 5 landmarks.
  • For each of the existing city the landmarks have been added
  • Bug Fix
  • Documentation change
  • Added a new city
  • Other(s)

Why was this change needed?

Closes #16

Other information

@dyaramatreya
Copy link
Contributor Author

@thenishantsapkota Please review the above changes.

Copy link
Contributor

@thenishantsapkota thenishantsapkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the landmarks properly and fact check it before adding them

data/borderlines.json Outdated Show resolved Hide resolved
data/borderlines.json Outdated Show resolved Hide resolved
data/borderlines.json Outdated Show resolved Hide resolved
data/borderlines.json Outdated Show resolved Hide resolved
data/borderlines.json Outdated Show resolved Hide resolved
Copy link
Contributor

@thenishantsapkota thenishantsapkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thank you for your contribution @dyaramatreya!

@thenishantsapkota thenishantsapkota merged commit 02070e4 into Know-Nepal:main Oct 20, 2023
@dyaramatreya
Copy link
Contributor Author

Looks good to me! Thank you for your contribution @dyaramatreya!

Thanks @thenishantsapkota!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update atleast 5 landmarks for every city present in cities.json
2 participants