New Company Added #98
Conversation
gaurab-khanal
requested review from
thenishantsapkota,
bsantosh909 and
drishyakarki
as code owners
data/companies.json
Outdated
| @@ -544,6 +544,23 @@ | |||
| "youtube": null | |||
| } | |||
| }, | |||
| { | |||
| "name": "Karobar App", | |||
| "logoName": "karobar_app.png", | |||
There was a problem hiding this comment.
The filename format is karobarapp.png
There was a problem hiding this comment.
Just made the changes. You can review it.
data/companies.json
Outdated
| { | ||
| "name": "Karobar App", | ||
| "logoName": "karobar_app.png", | ||
| "establishedAt": null, |
There was a problem hiding this comment.
The establishedAt is a required field and is a unix timestamp. Please update it accordingly!
There was a problem hiding this comment.
This seems more like a product rather than a company, I don't think it suits well in this repository.
For future, we might want to create another repository which lists all the products developed by nepali companies that are available to use for public.
However, for now, I don't think this entry suits well in this repository.
Yeah, Just knew about this. I will edit with its Company name where it falls. |
| @@ -544,6 +544,23 @@ | |||
| "youtube": null | |||
| } | |||
| }, | |||
| { | |||
| "name": "Bytecare Technology", | |||
There was a problem hiding this comment.
The information must be arranged alphabetically.
Co-authored-by: Susan Shrestha <thesusanshrestha@gmail.com>
What kind of change does this PR introduce?
Why was this change needed?
Other information