-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symfony 7, drop doctrine/annotations? #743
Comments
Symfony 7 is now in RC2, and will be released within the next 3 days. What do you think of at least bumping the minimum requirements for Symfony to 6.3? "symfony/cache": "^5.4|^6.0",
"symfony/dependency-injection": "^5.4|^6.0",
"symfony/http-kernel": "^5.4|^6.0",
"symfony/security-core": "^5.4|^6.0",
"symfony/framework-bundle": "^5.4|^6.0", I can help with testing, and can probably provide some PR's, but I was hoping the maintainers could set up a branch with the minimum requirements first. My preference is to only support PHP 8 so that everything can be done with attributes, and PHP 7 is at EOL. Perhaps a Version 3 of DoctrineBehaviors that just supports PHP 8.1 / Symfony 6.4/7.0? There hasn't been a release of this excellent package in over 2 years (Aug, 2021). |
Hi, Symfony 7 is now out. What's the best path to support it? |
Hi @tacman, this is a call for concern with this nice package. |
Hi, On my fork https://github.com/jfsenechal/DoctrineBehaviors/tree/sf7.0
All tests passed To use it in your project add "repositories": [
{
"type": "vcs",
"url": "https://github.com/jfsenechal/DoctrineBehaviors"
}
],
{
"knplabs/doctrine-behaviors": "dev-sf7.0 as 2.6.3",
} I hope my work can be used https://github.com/jfsenechal/DoctrineBehaviors/commits/sf7.0 |
Thanks, @jfsenechal I'll give it a try this week. As I mentioned before, I'm pretty convinced this is worthy of a new release, 6.4||7.0, and eventually supports the new Doctrine. Perhaps you can be added as a maintainer. |
I am willing to help you contribute according to my available time. |
Any update on this one? Is someone working on it or should I go ahead and create a PR? |
What's the status here? Symfony 7 compatibility would be great. |
any update on this? |
I asked KNP and they confirmed that they will be working and releasing an update. But no estimations on when so far. |
Any news? |
Latest release is : 2021Aug 9. |
best bet is to start with https://github.com/jfsenechal/DoctrineBehaviors, but ideally @jfsenechal would become a maintainer and simply release a new version with the higher PHP requirements and of course Symfony 7. And the new dbal/orm from doctrine are out, ideally this package would support, or at least allow the newer versions. |
@tacman +++ |
+++ |
:( |
@jfsenechal can you please rename your fork and publish it on packagist? This happened with the gedmo extensions for a while as well, and then eventually the changes were merged back, but it was a looong time, to the point that even the Symfony documentation referenced the fork. Alternatively, if you become a maintainer, please publish a release asap, bump the version if there's an issue with BC. Thanks! |
Since I'm constantly forgetting how to install jfsenechal's fork, here's a cut-and-paste solution: composer config repositories.jfsenechal_doctrine_behaviors '{"type": "vcs", "url": "git@github.com:jfsenechal/DoctrineBehaviors.git"}'
composer require knplabs/doctrine-behaviors:"dev-sf7.0 as 2.6.3" |
Thanks @jfsenechal for your work on the updated fork and @tacman for the quick copy & paste solution. What's with the holdup in making this official? |
Symfony 7 is now in beta.
I think the biggest change will be in listeners v subscribers. If the next version only supported 8.1+ and Symfony 6+, we could migrate to attributes.
We could also drop doctrine/annotations as a dependency then.
The text was updated successfully, but these errors were encountered: