feat: add typehint on adapter #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinArtus
force-pushed
the
feat/add-type-adapter
branch
from
072b450
to
7ef46f7
Compare
Zusoy
suggested changes
May 11, 2023
muchafm
force-pushed
the
feat/add-type-adapter
branch
2 times, most recently
from
8bd80cc
to
f16ad45
Compare
muchafm
suggested changes
May 26, 2023
PedroTroller
requested changes
Jun 12, 2023
Co-authored-by: Kévin <kevinar9@outlook.fr>
Co-authored-by: Kévin <kevinar9@outlook.fr>
Co-authored-by: Kévin <kevinar9@outlook.fr>
Co-authored-by: Kévin <kevinar9@outlook.fr>
PedroTroller
force-pushed
the
feat/add-type-adapter
branch
from
3ce2ceb
to
a96fcb2
Compare
PedroTroller
force-pushed
the
feat/add-type-adapter
branch
from
a96fcb2
to
bf12aef
Compare
Co-authored-by: Grégoire Drapeau <gregoire.drapeau79@gmail.com>
KevinArtus
commented
Oct 30, 2023
KevinArtus
commented
Oct 30, 2023
KevinArtus
commented
Oct 30, 2023
KevinArtus
commented
Oct 30, 2023
Co-authored-by: Kévin <kevinar9@outlook.fr>
Co-authored-by: Kévin <kevinar9@outlook.fr>
Co-authored-by: Kévin <kevinar9@outlook.fr>
KevinArtus
commented
Oct 30, 2023
muchafm
approved these changes
Oct 30, 2023
Co-authored-by: Kévin <kevinar9@outlook.fr>
PedroTroller
approved these changes
Oct 30, 2023
PedroTroller
added a commit
that referenced
this pull request
Feb 26, 2024
* feat: add typehint on adapter * Type interface for adapters * Type AsyncAwsS3 * Type AwsS3 * Type AzureBlobStorage * Type DoctrineDbal * fix constructor AsyncAwsS3 * Type Flysystem * Type PhpseclibSftp * Type Zip * Type GridFS and fix declaration checksum * fix muchafm review * refacto: add types on adapter * fix: review * fix: review * Refacto: Add type on Stream classes * fix pedro review * refactor: add typeint to FilesystemMap, StreamWrapper and StreamMode * Refacto: Add type on Util classes * fix muchafm review * fix: pedro review * fix pedro's review * refacto: spec types * fix: review * refactor: fix Ftp and StreamWrapper errors * refactor: fix lvl5 errors for AwsS3 and AzureBlobStorage adapters * ci: upgrade phpstan to 1.10.39 * test: fix filesystem typehint in phpunit tests * fix: fix phpspec tests * refactor: apply cs fixing * test: fix phpspec tests * Update src/Gaufrette/Adapter/AwsS3.php Co-authored-by: Grégoire Drapeau <gregoire.drapeau79@gmail.com> * Update src/Gaufrette/Adapter/PhpseclibSftp.php Co-authored-by: Grégoire Drapeau <gregoire.drapeau79@gmail.com> * Update src/Gaufrette/Adapter/AzureBlobStorage.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Adapter.php * Update src/Gaufrette/Adapter/AzureBlobStorage.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Adapter/Ftp.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Adapter/AzureBlobStorage.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Adapter/DoctrineDbal.php * refactor: set type for mimetype aware adapters * docs: add explanation for bitwire value in StreamWrapper * fix: introduction of readonly promoted properties * Update src/Gaufrette/Adapter/AwsS3.php Co-authored-by: Grégoire Drapeau <gregoire.drapeau79@gmail.com> * Update src/Gaufrette/Stream/InMemoryBuffer.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Stream/Local.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Stream/Local.php Co-authored-by: Kévin <kevinar9@outlook.fr> * Update src/Gaufrette/Adapter/AsyncAwsS3.php * Update src/Gaufrette/Stream/InMemoryBuffer.php Co-authored-by: Kévin <kevinar9@outlook.fr> --------- Co-authored-by: Sophie Roussel <sophie.roussel@knplabs.com> Co-authored-by: PedroTroller <pierre.plazanet@knplabs.com> Co-authored-by: Grégoire Drapeau <gregoire.drapeau79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.