-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_vulkan_version.cmake
and MoltenVK
#378
Comments
@kwsp thank you for reporting, indeed as per PR I also noticed this strange bug, I agree that a simple CMAKE disable may be a better workaround until the bug is fixed, let's go for that. For the time being, I would be keen on opening an issue on moltenvk and/or vulkan repos to report this issue. |
Opened KhronosGroup/MoltenVK#2292 |
Following up, KhronosGroup/MoltenVK#2292 confirmed the following: Based on this we should explore on having an explicit error message on MoltenVK/MacOS machines with a link to the MoltenVK issue that is looking to add 1.3 support KhronosGroup/MoltenVK#1930 @kwsp would you be interested to add a small PR on this? Alternatively we can look at this |
@axsaucedo Sure! I'll work on a small PR to emit an error message on mac with your suggestion. |
Great @kwsp - thanks for the contribution |
Edit - adding response from KhronosGroup/MoltenVK#2292:
On a M1 mac with the latest MoltenVK implementation of Vulkan (I'm using
molten-vk
from Homebrew, which is Molten VK 1.2.10 and implements Vulkan API 1.3.275), Kompute builds with the flag (-DKOMPUTE_OPT_DISABLE_VULKAN_VERSION_CHECK=ON
). However,check_vulkan_version.cmake
seems to be broken.This is kinda known to Kompute given this PR disables the vulkan version check to build for mac
https://github.com/KomputeProject/kompute/pull/353/files
I'm reading the source code for
check_vulkan_version.cmake
and it just parses the output ofvulkaninfo
.Output of vulkaninfo on a M1 mac
Notice at the top
Vulkan Instance Version: 1.3.275
, but at the bottom the physical device property of GPU0 saysapiVersion = 1.2.275
(whichcheck_vulkan_version.cmake
parses, compares with the Vulkan header version, and complains about). I'm not sure if this is a bug invulkaninfo
or the Molten VK driver (that apiVersion is stated as 1.2.275, since it clearly supports 1.3.275. I think this is a MoltenVKThe text was updated successfully, but these errors were encountered: