Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fmt include in Manager #390

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kwsp
Copy link
Contributor

@kwsp kwsp commented Aug 21, 2024

When building with -DKOMPUTE_OPT_USE_BUILT_IN_FMT=OFF using fmt from vcpkg, I was getting build errors in Manager.cpp saying error: no member named 'join' in namespace 'fmt'. join is defined in <fmt/ranges.h> which wasn't included. I'm not sure how kompute can build with the built in fmt.

Another trivial thing was that the <set> and <unordered_map> headers were not used in Manager.hpp so I moved them to Manager.cpp.

Signed-off-by: tnie <tnie@tuta.io>
@kwsp
Copy link
Contributor Author

kwsp commented Aug 21, 2024

This problem is blocking the vcpkg port of Kompute I'm working on

Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thank you for the fix @kwsp - LGTM

@axsaucedo axsaucedo merged commit fdf4098 into KomputeProject:master Aug 21, 2024
8 checks passed
@kwsp
Copy link
Contributor Author

kwsp commented Aug 21, 2024

I should mention that the fmt version downloaded by kompute in CMake is very old (8.x), while the current major release that VCPKG installs is 11.x. and the API might've changed. I think we should update the fmt downloaded by fmt in CMake too

@axsaucedo
Copy link
Member

@kwsp I agree with you - I remember having a look at this but seeing some strange errors so ended up not prioritising, but certainly something I'd be up for if you were able to perform the update to latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants