Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for using uninitialised tensors. #391

Conversation

robquill
Copy link
Contributor

Modify the ReserveData test to test some different ways of creating uninitialised tensors.

Remove the test which tests that the size of an uninitialised tensor is zero, as the tensor does have a size it just has no data.

Modify the ReserveData test to test some different ways of creating
uninitialised tensors.

Remove the test which tests that the size of an uninitialised tensor is
zero, as the tensor does have a size it just has no data.

Signed-off-by: Robert Quill <robert.quill@imgtec.com>
@robquill robquill force-pushed the nocopy_constructor_improvements branch from 5c03f3d to 5bd5bef Compare August 21, 2024 13:00
@robquill
Copy link
Contributor Author

@ThePseudo , I'd be interested in your review of this. I had independently done something similar so have merged my changes on top of yours.

Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I don't see why not adding this, thank you @robquill - LGTM

@axsaucedo axsaucedo merged commit 8f096a7 into KomputeProject:master Aug 21, 2024
8 checks passed
@robquill robquill deleted the nocopy_constructor_improvements branch September 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants