Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a build error in macos #397

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

randyli
Copy link
Contributor

@randyli randyli commented Sep 23, 2024

There is a compile error in MacOS
'recordCopyFrom' overrides a member function but is not marked 'override'

Signed-off-by: Randy Lee 155058195@qq.com

@axsaucedo
Copy link
Member

Thank you @randyli - seems good, please update DCO so we can approve

Signed-off-by: randyli <155058195@qq.com>
@randyli
Copy link
Contributor Author

randyli commented Sep 27, 2024

Thank you @randyli - seems good, please update DCO so we can approve

seems done 😄

Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axsaucedo axsaucedo merged commit cfe4fd6 into KomputeProject:master Sep 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants