Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use 1 namespace for ct install tests #1141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 11, 2024

What this PR does / why we need it:

It seems that using a separate namespace for each test in ct install ... take a lot of time to delete the namespace completely:

Fri, 11 Oct 2024 12:38:46 GMT Deleting release "kong-qpo65402jm"...
Fri, 11 Oct 2024 12:38:46 GMT release "kong-qpo65402jm" uninstalled
Fri, 11 Oct 2024 12:38:46 GMT Deleting namespace "kong-qpo65402jm"...
Fri, 11 Oct 2024 12:38:46 GMT namespace "kong-qpo65402jm" deleted
Fri, 11 Oct 2024 12:39:12 GMT Namespace "kong-qpo65402jm" terminated.

Instead we can use just 1 namespace and share it which greatly decreases the time required for the test suite to run:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pmalek pmalek force-pushed the use-1-namespace-in-ct-install-tests branch from 507a0fe to 6d8a72f Compare October 11, 2024 14:05
@pmalek pmalek marked this pull request as ready for review October 11, 2024 14:34
@pmalek pmalek requested a review from a team as a code owner October 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant